Fallback to line formatter on missing cli dumper #145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symfony-bot
previously approved these changes
Aug 3, 2017
|
Some context: the original issue was that the application didn't have VarDumper installed and then the logs were poorly formatted: no context, no extra, etc. |
The ConsoleFormatter is not so great when it does not come configured with a dumper: context and extra keys are not shown at all. A better fix might be to provide a poor man's dumper when the var dumper component is not installed.
greg0ire
force-pushed
the
formatter_fallback
branch
from
dd94767 to
472ae0a
Compare
symfony-bot
approved these changes
Aug 3, 2017
|
@javiereguiluz I added more context in the commit message. |
|
Shouldn't this be directly managed in MonologBundle? |
|
@sroze you mean like this?
Or should |
|
I would indeed fix this issue upstream, instead of adding a workaround here. |
|
ping @greg0ire |
|
@nicolas-grekas I'll try to have a look at that soonish |
|
@nicolas-grekas here you go: symfony/symfony#24598 |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 24, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Prefer line formatter on missing cli dumper | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none, but closes symfony/recipes#145 | License | MIT | Doc PR | n/a The console formatter does a better job, unless the VarDumper component is missing, in which case the LineFormatter should be preferred. Commits ------- 574f9f5 Prefer line formatter on missing cli dumper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConsoleFormatter is not so great when it does not come configured
with a dumper. A better fix might be to provide a poor man's dumper when
the var dumper component is not installed.