Clarify when you would uncomment the session config #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
Pierstoval
approved these changes
Dec 11, 2017
fabpot
approved these changes
Dec 11, 2017
xabbuh
approved these changes
Dec 11, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
Honestly, the session is a bit of a usability issue - see #262. This at least clarifies what's going on in this file - e.g. "Do I need to uncomment this? Or is the default value ok for my tests?". This was added in #223 so the test environment was consistent with the other environments (no session by default). That was the correct decisions... but this session stuff is annoying (you need to remember to uncomment it in 2 places now).