Skip to content

[framework-bundle] git-ignore prod.sodium.decrypt.private #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Oct 27, 2019
Merged

[framework-bundle] git-ignore prod.sodium.decrypt.private #656

1 commit merged into from
Oct 27, 2019

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT
Doc issue/PR -

To merge after symfony/symfony#33997

ghost
ghost approved these changes Oct 16, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

weaverryan
weaverryan reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filename was ultimately a bit different, right?

ghost
ghost approved these changes Oct 26, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas nicolas-grekas changed the title [framework-bundle] git-ignore prod.sodium.decrypt.key [framework-bundle] git-ignore prod.sodium.decrypt.private Oct 26, 2019
ghost
ghost approved these changes Oct 26, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Oct 26, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas
Copy link
Member Author

Updated

ghost pushed a commit that referenced this pull request Oct 27, 2019
Merge pull request #656
7be9ee0
@ghost ghost merged commit 7764bbb into symfony:master Oct 27, 2019
@nicolas-grekas nicolas-grekas deleted the secrets branch November 28, 2019 08:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @weaverryan @chalasr