[Mercure] Fix enable_profiler node position #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Nov 8, 2019
chalasr
commented
| Q | A |
|---|---|
| License | MIT |
| Doc issue/PR | - |
ghost
deployed
to
|
Actually |
ghost
suggested changes
Nov 8, 2019
|
Right, fixed! |
dunglas
requested changes
Nov 8, 2019
ghost
suggested changes
Nov 8, 2019
chalasr
force-pushed
the
mercure-fix
branch
2 times, most recently
from
682098f to
26c23cb
Compare
ghost
suggested changes
Nov 8, 2019
dunglas
approved these changes
Nov 8, 2019
|
The validation error is because the master branch has alias 1.0.x-dev, not 0.3.x-dev (which looks wrong to me btw, if you plan multiple 0.x releases before reaching 1.0, with BC breaks between them) |
|
Also, why 0.3 ? There is no 0.2 release yet |
|
You’re right, the next bundle version is 0.2 (I mixed with the library version). And you’re also right about the branch alias. Both the bundle and the lib must be updated. |
ghost
suggested changes
Nov 8, 2019
ghost
suggested changes
Nov 8, 2019
|
This PR can now be merged (the CI will be green now). |
|
Green |
nicolas-grekas
approved these changes
Nov 9, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.