Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSet NODE_ENV var when running Encore scripts #747
Conversation
|
Pull request passes validation. |
|
Pull request passes validation. |
| "dev-server": "NODE_ENV=development encore dev-server", | ||
| "dev": "NODE_ENV=development encore dev", | ||
| "watch": "NODE_ENV=development encore dev --watch", | ||
| "build": "NODE_ENV=production encore production --progress" |
This comment has been minimized.
This comment has been minimized.
Lyrkan
Mar 24, 2020
Contributor
For portability reasons something like cross-env should also probably be used.
This comment has been minimized.
This comment has been minimized.
weaverryan
Mar 28, 2020
Member
Yes, if we do this, then we need to use cross-env. I was always hoping to avoid that.
An alternative might be documentation? Couldn't we advise people to set this env var (of some other env var) inside webpack.config.js if they want to? Like:
// webpack.config.js
process.env. NODE_ENV = Encore.isProduction() ? 'production' : 'development';
WDYT?
This comment has been minimized.
This comment has been minimized.
javiereguiluz
Mar 31, 2020
Author
Member
I made some changes according to your comments. What do you think? Thanks.
|
Pull request passes validation. |
|
Pull request passes validation. |
| @@ -1,5 +1,9 @@ | |||
| var Encore = require('@symfony/webpack-encore'); | |||
|
|
|||
| // Optional: sync the NODE_ENV value with the current webpack environment | |||
| // It's useful when you configure tools like PostCSS in their own config files instead of in webpack.config.js. | |||
This comment has been minimized.
This comment has been minimized.
weaverryan
Apr 5, 2020
Member
I’d change this to:
It’s useful if you need to read the environment from some other config file
The key difference is that I want people to know that this change doesn’t cause any behavior to change, it’s just something you can use if you want yourself.
javiereguiluz commentedMar 24, 2020
•
edited
In a project I needed to enable PurgeCSS only when in production. This is done in postcss.config.js and there's no way to know if Encore is running in production or not. I asked on Slack and @Lyrkan proposed this solution to me. It worked for me nicely!
As I think this could be useful to others, I propose this change in case it makes sense to make it in general for all projects.