Set NODE_ENV var when running Encore scripts #747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
Lyrkan
reviewed
Mar 24, 2020
weaverryan
reviewed
Apr 5, 2020
|
@Lyrkan @weaverryan what do you think about this proposal after the latest changes that you suggested? Should we add this or close it as "won't fix"? Thanks! |
Lyrkan
approved these changes
Jul 2, 2020
noniagriconomie
approved these changes
Nov 17, 2020
stof
requested changes
Nov 17, 2020
| @@ -1,5 +1,9 @@ | |||
| var Encore = require('@symfony/webpack-encore'); | |||
|
|
|||
| // Optional: sync the NODE_ENV value with the current Webpack Encore environment | |||
| // It’s useful if you need to read the Webpack Encore environment from some other config file | |||
| // process.env.NODE_ENV = Encore.isProduction() ? 'production' : 'development'; | |||
There was a problem hiding this comment.
this should be moved after the Manually configure the runtime environment case
|
I love this idea :) |
|
Please rebase so that the new checks can run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project I needed to enable PurgeCSS only when in production. This is done in postcss.config.js and there's no way to know if Encore is running in production or not. I asked on Slack and @Lyrkan proposed this solution to me. It worked for me nicely!
As I think this could be useful to others, I propose this change in case it makes sense to make it in general for all projects.