Add local Docker config for Mailer #989
Conversation
ghost
deployed
to
Diff between recipe versionsThanks for the PR 😍 In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
fabpot
force-pushed
the
docker-mailer-support
branch
from
bb15e83 to
16519e7
Compare
| @@ -5,5 +5,14 @@ | |||
| "env": { | |||
| "#1": "MAILER_DSN=smtp://localhost" | |||
| }, | |||
| "docker-compose": { | |||
| "docker-compose.override.yml": { | |||
| "services": [ | |||
There was a problem hiding this comment.
It would be nice to move this to a separate file to instead of writing (maybe more complex) services in json
This is more a feature request/idea for flex.
WDYT?
There was a problem hiding this comment.
We discuss this in the past, and IIRC, we did this as we already had all the infrastructure to update files with data from the manifest. We might want to revisit this indeed as doing it in a JSON file is not optimal to say the least :)
There was a problem hiding this comment.
Thanks for the feedback 👌🏻
When using the Mailer locally, let's use a mail catcher automatically.
/cc @dunglas