Skip to content

Commit

Permalink
fixup! Document changes in the deprecation error handler
Browse files Browse the repository at this point in the history
  • Loading branch information
Olena Kirichok authored and javiereguiluz committed May 31, 2019
1 parent b2a7744 commit dd7eb0b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 3 additions & 3 deletions components/phpunit_bridge.rst
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ shifts the burden of fixing that deprecation to any contributor that
happens to submit a pull request shortly after a new vendor release is
made with that deprecation. To mitigate this, you can either use tighter
requirements, in the hope that dependencies will not introduce
deprecations in a patch version, or even commit the Composer lock file,
deprecations in a patch version, or even commit the ``composer.lock`` file,
which would create another class of issues. Libraries will often use
``SYMFONY_DEPRECATIONS_HELPER=max[total]=999999`` because of this. This
has the drawback of allowing contributions that introduce deprecations
Expand All @@ -227,7 +227,7 @@ be accounted for seperately, while deprecations triggered from a library
inside it will not (unless you reach 999999 of these), giving you
the best of both worlds.

Direct and indirect deprecations
Direct and Indirect Deprecations
................................

When working on a project, you might be more interested in
Expand Down Expand Up @@ -258,7 +258,7 @@ Here is a summary that should help you pick the right configuration:
| | cannot afford to use one of the modes above. |
+------------------------+-----------------------------------------------------+

Disabling the verbose output
Disabling the Verbose Output
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

By default, the bridge will display a detailed output with the number of
Expand Down
6 changes: 5 additions & 1 deletion setup/upgrade_major.rst
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ done!
</php>
</phpunit>
(you can also execute the command like ``SYMFONY_DEPRECATIONS_HELPER=max[total]=999999 phpunit``).
You can also execute the command like:

.. code-block:: terminal
$ SYMFONY_DEPRECATIONS_HELPER=max[total]=999999 phpunit
.. _upgrade-major-symfony-composer:

Expand Down

0 comments on commit dd7eb0b

Please sign in to comment.