Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link for documentation page of DotEnv Component returns 404 Not Found #7526

Closed
felipsmartins opened this issue Feb 23, 2017 · 7 comments
Closed
Labels
bug hasPR A Pull Request has already been submitted for this issue. Status: Reviewed Website

Comments

@felipsmartins
Copy link

felipsmartins commented Feb 23, 2017

Browsing to DotEnv Component doc deals with a 404 page not found.
How to reproduce:

  1. Go to http://symfony.com/
  2. Click on the Browse components link
  3. Go to Component List and click on Dotenv (you could to click on the link in the third column for docs and it has the same effect - 404)

Now in the Dotenv component main page click on Documentation. It returns a 404 Not Found.

selecao_109

Note

Swapping current segment of URL to master it works.

selecao_110

@javiereguiluz
Copy link
Member

Yes, the problem is exactly what you said: current today points to 3.2, but DotEnv only exists in 3.3+

Should we remove this component until May 2017 when current turns into 3.3?

@javiereguiluz
Copy link
Member

I'm trying to fix this via symfony/marketing#381

@javiereguiluz javiereguiluz added hasPR A Pull Request has already been submitted for this issue. Status: Reviewed and removed Status: Needs Review labels Mar 4, 2017
@linaori
Copy link
Contributor

linaori commented Mar 4, 2017

Can't it automatically create a link to the version that is available? A master version should always be available if there's no tagged version.

@javiereguiluz
Copy link
Member

@iltar a bug fix has been proposed and if merged/deployed, this could be soon fixed. Thanks!

@javiereguiluz
Copy link
Member

Closing it as fixed because the http://symfony.com/doc/current/components/dotenv.html page now displays a proper error message with a link to the "master" doc:

dotenv-doc

@bitdagger
Copy link

bitdagger commented Mar 16, 2017

As a heads up, the documentation link in the DotEnv Repo is currently set to https://symfony.com/doc/current/components/dotenv/index.html rather than the URL referenced in this issue, http://symfony.com/doc/current/components/dotenv.html

While the link referenced here does have a link on the page to the master URL, the link in the DotEnv repo is a generic 404 with no link to master (or anything else relevant).

@wouterj
Copy link
Member

wouterj commented Mar 16, 2017

@bitdagger thanks for reporting it. Can you maybe submit a PR to symfony/symfony to fix the link in the README.md file? The link should be updated to link to the correct one, .../components/dotenv.html

bitdagger pushed a commit to bitdagger/symfony that referenced this issue Mar 16, 2017
fabpot added a commit to symfony/symfony that referenced this issue Mar 16, 2017
This PR was merged into the 3.3-dev branch.

Discussion
----------

Fix dotenv documentation link

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see comment below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | <!--highly recommended for new features-->

Replaces the Documentation link for the DotEnv component with the correct link.

Context: symfony/symfony-docs#7526 (comment)

Commits
-------

8810d61 Fix dotenv documentation link
symfony-splitter pushed a commit to symfony/dotenv that referenced this issue Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug hasPR A Pull Request has already been submitted for this issue. Status: Reviewed Website
Projects
None yet
Development

No branches or pull requests

6 participants