[Console] Document console completion #16723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
force-pushed
the
console-completion
branch
from
be5a15d
to
1ef3879
Compare
javiereguiluz
approved these changes
Apr 21, 2022
wouterj
force-pushed
the
console-completion
branch
from
1ef3879
to
90acaca
Compare
|
Thank you @wouterj. Do you think this page should be updated for 6.1 with the new features: fish completion symfony/symfony#43641 and configuration in option/argument définition symfony/symfony#44948 |
GromNaN
reviewed
Apr 21, 2022
|
|
||
| // complete the input with "Fa" as input | ||
| $suggestions = $tester->complete(['Fa']); | ||
| $this->assertSame(['Fabien', 'Fabrice'], $suggestions); |
There was a problem hiding this comment.
Users will think they need to filter the values themself, while this is done by the completion tool.
I think getCompletionValue usage is rare and reserved to cases when the list of values is too long (like the list of all packages on packagist composer/composer#10320 (comment))
Yes, see #16724 (would be great to get your review there) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15947
I couldn't resist rewriting the Console document a bit, to structure it more like "Usage" and "Implementing a custom command". This created a nice place to talk about setting up completion.