Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let docbot review the form docs #5263

Merged
merged 2 commits into from
May 23, 2015
Merged

Let docbot review the form docs #5263

merged 2 commits into from
May 23, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented May 17, 2015

Q A
Doc fixes? yes
New docs? no
Applies to 2.3+
Fixed tickets -

wouterj
wouterj reviewed May 17, 2015
View reviewed changes
reference/forms/types/birthday.rst
@@ -1,13 +1,13 @@
.. index::
single: Forms; Fields; birthday

birthday Field Type
Birthday Field Type
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really follow why we lowercased the name here each time. Do you agree with capitializing them @symfony/team-symfony-docs ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I see with changing this is that people then may think that the have to use Birthday instead of birthday in their code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we use birthday because it's basically birthday is the case-sensitive field type name. So I think we need to keep this lowercased.

@weaverryan weaverryan merged commit 55246be into symfony:2.3 May 23, 2015
weaverryan added a commit that referenced this pull request May 23, 2015
@weaverryan
minor #5263 Let docbot review the form docs (WouterJ)
a815378 
This PR was merged into the 2.3 branch.

Discussion
----------

Let docbot review the form docs

| Q | A
| --- | ---
| Doc fixes? | yes
| New docs? | no
| Applies to | 2.3+
| Fixed tickets | -

Commits
-------

55246be Updated types articles
03fdc5b Reviewed form type options includes
@weaverryan
Copy link
Member

All hail robot overlords! 💻

@wouterj wouterj deleted the doc_fixes_form_options branch May 23, 2015 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @weaverryan @xabbuh