Some fixes for bundle best practices #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
May 25, 2015
wouterj
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | - |
| @@ -155,13 +142,13 @@ Classes | |||
|
|
|||
| The bundle directory structure is used as the namespace hierarchy. For | |||
| instance, a ``HelloController`` controller is stored in | |||
There was a problem hiding this comment.
This phrase looks confusing to me:
A HelloController is stored in HelloBundle/Controller/HelloController.php
and the fully qualified class name is ...
It seems like it's mandatory to store the controller in that exact path (but only the controller name is mandatory). What about changing it slightly by:
If a HelloController is stored in HelloBundle/Controller/HelloController.php,
the fully qualified class name is ...
|
👍 great changes Wouter! Thanks. |
wouterj
force-pushed
the
bundle-best-practices
branch
from
f17cf49
to
c2f39b4
Compare
weaverryan
added a commit
that referenced
this pull request
Aug 8, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Some fixes for bundle best practices | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- c2f39b4 Some fixes for bundle best practices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.