Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a note about session data size in PdoSessionHandler #5516

Closed
wants to merge 2 commits into from
Closed

Added a note about session data size in PdoSessionHandler #5516

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets #5269

xabbuh
xabbuh reviewed Jul 14, 2015
View reviewed changes
cookbook/configuration/pdo_session_storage.rst
@@ -172,15 +172,18 @@ of your project's data, you can use the connection settings from the
'%database_password%',
));

Example SQL Statements
----------------------
.. example-sql-statements::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be:

.. _example-sql-statements:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

@xabbuh
Copy link
Member

xabbuh commented Jul 15, 2015

👍

wouterj added a commit that referenced this pull request Jul 23, 2015
@wouterj
feature #5516 Added a note about session data size in PdoSessionHandl…
c9f3850 
…er (javiereguiluz)

This PR was squashed before being merged into the 2.3 branch (closes #5516).

Discussion
----------

Added a note about session data size in PdoSessionHandler

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #5269

Commits
-------

a52b159 Added a note about session data size in PdoSessionHandler
wouterj added a commit that referenced this pull request Jul 23, 2015
@wouterj
[#5516] Change note to caution
fc9dd41
@wouterj
Copy link
Member

wouterj commented Jul 23, 2015

Thanks @javiereguiluz! I've changed the directive to a caution directive in fc9dd41, as I think it better fits the content (and it is actually quite important information). As always, let me know if you don't agree with that change :)

@wouterj wouterj closed this Jul 23, 2015
@javiereguiluz javiereguiluz deleted the fix_5269 branch May 24, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @xabbuh @wouterj