Removed reference to remove HTTPS off from nginx configuration #5536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
Thank you @wjzijderveld. |
xabbuh
added a commit
that referenced
this pull request
Jul 23, 2015
…ation (wjzijderveld) This PR was merged into the 2.3 branch. Discussion ---------- Removed reference to remove HTTPS off from nginx configuration | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #5517 As explained and confirmed in #5517 the `https off` flag could be causing issues, in my opinion it's better to rely on the defaults distributions give. An alternative would be to replace the lines with `HTTPS $https;`, [nginx will fill $https depending on current request](http://nginx.org/en/docs/http/ngx_http_core_module.html#var_https). But I think it's less confusing if we just let the lines out of the example. Commits ------- 3878e14 Removed reference to remove HTTPS off from nginx configuration
wachterjohannes
pushed a commit
to sulu/docs
that referenced
this pull request
Aug 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained and confirmed in #5517 the
https offflag could be causing issues, in my opinion it's better to rely on the defaults distributions give.An alternative would be to replace the lines with
HTTPS $https;, nginx will fill $https depending on current request. But I think it's less confusing if we just let the lines out of the example.