[2.3] [Contributing] [CS] Added missing docblocks in code snippet #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phansys
commented
Jul 24, 2015
phansys
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | no |
| Applies to | |
| Fixed tickets |
| * @param string $dummy Some argument description | ||
| * Transforms the input given as first argument. | ||
| * | ||
| * @param string $dummy Some argument description | ||
| * @param array $options |
There was a problem hiding this comment.
What about a description for the $options argument and the exception?
| Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | | Fixed tickets |
|
👍 (although we have a very weird example here now, we might need to rewrite it and have something more logical in the future...) |
|
👍 |
|
👍 |
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Sep 5, 2015
… snippet (phansys) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5560). Discussion ---------- [2.3] [Contributing] [CS] Added missing docblocks in code snippet | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | | Fixed tickets | Commits ------- 8395e66 [2.3] [Contributing] [CS] Added missing docblocks in code snippet
|
Thank you @xabbuh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.