Fix monolog line formatter in logging cookbook example. #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good |
|
Thank you @xabbuh Is there anything else required from me? This is my 1st contribution and I am not sure. |
wouterj
added a commit
that referenced
this pull request
Sep 5, 2015
…arquez) This PR was merged into the 2.3 branch. Discussion ---------- Fix monolog line formatter in logging cookbook example. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | After [Adding some extra Data in the Log Messages](http://symfony.com/doc/current/cookbook/logging/monolog.html#adding-some-extra-data-in-the-log-messages), logs were missing some detail (like missing translation tokens on translation.WARNING messages). I've corrected the line formatter adding missing tokens taken from [Monolog/Formatter/LineFormatter.php](https://github.com/Seldaek/monolog/blob/master/src/Monolog/Formatter/LineFormatter.php). Example, log entries before adding extra data: ``` [2015-08-25 14:24:58] translation.WARNING: Translation not found. {"id":"GeoCountryReg.labels.imageFile1","domain":"messages","locale":"es"} [] ``` And after: ``` [2015-08-25 14:27:29] [cutptr3q-f0d64b15] translation.WARNING: Translation not found. ``` Desired effect was: ``` [2015-08-25 14:36:18] [cutptr3q-3b0c7c83] translation.WARNING: Translation not found. {"id":"GeoCountryReg.labels.imageFile1","domain":"messages","locale":"es"} [] ``` Commits ------- 6c6ed2a Fix monolog line formatter in logging cookbook example.
|
Hi @vmarquezh! After your PR has a "finished" label, you just have to wait till one of us has time to review & merge your PR. I've merged your PR into the documentation now. Thank you for submitting it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Adding some extra Data in the Log Messages, logs were missing some detail (like missing translation tokens on translation.WARNING messages).
I've corrected the line formatter adding missing tokens taken from Monolog/Formatter/LineFormatter.php.
Example, log entries before adding extra data:
And after:
Desired effect was: