replacing deprecated usage of True, False, Null validators in docs #5677
Conversation
|
Nice work @stampycode. These changes should imo be made for the @stampycode Is this based off the |
|
This is based off |
|
I think it's totally fine if we merge it into the @weaverryan @wouterj @javiereguiluz What do you think? |
|
@xabbuh I agree with you. Let's merge it in 2.3 because this change was exceptionally made in that branch too. |
|
|
||
| .. include:: /reference/constraints/_payload-option.rst.inc | ||
| .. include:: /reference/constraints/IsFalse.rst |
There was a problem hiding this comment.
instead of including the IsFalse documentation, I prefer to add a link to this docs in the caution above. So we end up with:
.. caution::
The ``False`` constraint is deprecated since Symfony 2.7 and will
be removed in 3.0. Use the :doc:`/reference/constraints/IsFalse` constraint
instead.
There was a problem hiding this comment.
btw, including it does weird things, as it also includes the title
|
👍 for 2.3 - if that's what we did in the code |
…ors in docs (Tim Stamp) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5677). Discussion ---------- replacing deprecated usage of True, False, Null validators in docs related: #5665 Commits ------- 9a5ea56 Updating book examples to not use deprecated validation methods 627d74d Updated constraint reference docs for Null->IsNull, False->IsFalse, True->IsTrue a90ea7c Creating placeholder constraint rst docs for deprecated usage 639be4b Renaming constraint rst files to Is* to preserve edit history
|
Thanks @stampycode! I've merged this into the 2.3 branch and merged up from there. |
related: #5665