Added caution to call createView after handleRequest #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Be aware that the ``createView()`` method should be called *after* ``handleRequest`` | ||
| is called. Otherwise, changes done in the ``*_SUBMIT`` events aren't applied to the | ||
| view (like validation errors). |
There was a problem hiding this comment.
view (like validation errors) -> i.e. validation errors etc. ?
There was a problem hiding this comment.
What about "(like, for example, validation errors)"?
|
Thanks Wouter. |
xabbuh
added a commit
that referenced
this pull request
Oct 3, 2015
…terJ) This PR was merged into the 2.3 branch. Discussion ---------- Added caution to call createView after handleRequest | Q | A | --- | --- | Doc fix? | yes | New docs? | yes | Applies to | all | Fixed tickets | - Many thanks to *sidi* on IRC for catching this missing important information! Commits ------- a351d8a Added caution to call createView after handleRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to sidi on IRC for catching this missing important information!