use constants to choose generated URL type #5813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 20, 2015
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | symfony/symfony#16276 |
xabbuh
force-pushed
the
route-generate-type-argument
branch
from
fc151b3
to
50ecc55
Compare
This was referenced Oct 20, 2015
| @@ -271,6 +271,11 @@ controller: | |||
|
|
|||
| $router->generate($route, $params, $absolute); | |||
|
|
|||
| .. note:: | |||
|
|
|||
| The ``$absolute`` argument must be one of the constants defined in | |||
There was a problem hiding this comment.
The argument is actually named $referenceType in Symfony, not $absolute, as $absolute does not make sense anymore since it is not a simple boolean anymore.
I suggest to update the doc to use the uptodate name
xabbuh
force-pushed
the
route-generate-type-argument
branch
from
50ecc55
to
f00efff
Compare
|
👍 |
2 similar comments
|
👍 |
|
👍 |
|
These changes are a bit misleading because they are targeted at Symfony 2.3 but this change is deprecated in 2.8 and mandatory since 3.0. However, in this case, I agree with committing the changes to 2.3 and up. Thanks. 👍 |
|
Thanks! |
weaverryan
added a commit
that referenced
this pull request
Nov 5, 2015
This PR was merged into the 2.3 branch. Discussion ---------- use constants to choose generated URL type | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | symfony/symfony#16276 Commits ------- f00efff use constants to choose generated URL type
xabbuh
added a commit
that referenced
this pull request
Dec 14, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Fix missing constant usage for generating urls This was forgotten in #5813 as reported in symfony/symfony#16991 Commits ------- 2ecc541 Fix missing constant usage for generating urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.