"setup" is a noun or adjective, "set up" is the verb #5826
Conversation
Also, I don´t see any need for this to be capitalized
|
I intended to merge this with branch 2.3, not sure what I did wrong |
|
👍 for the fixed typo. Regarding the title case, Symfony uses a very strange title case variant which is mentioned here (http://symfony.com/doc/current/contributing/documentation/standards.html#english-language-standards). My guess is that this title: Should be spelled instead as: |
|
@javiereguiluz You are right about these weird english capitalization rules, changed to what you suggested |
|
👍 |
|
Actually, aren't "before" and "after" closed class words and need to be lowercased? |
|
Maybe you are right... what about "up"? Probably it should not be uppercase either. |
|
I am always confused about this rule too. :) Though I think "Up" should be uppercased as it is part of the verb. |
|
@GuGuss Is there an issue with our service hook or is there some other thing going wrong with our platform.sh integration? |
|
I found these pages with rules for capitalization: http://www.grammarcheck.net/capitalization-in-titles-101/ According to them the capitalization is correct now |
|
@xabbuh You're right this time ;) PRs aren't built anymore. I'll check what's happening. |
|
Thanks Carlos! This works for me! |
…los-granados) This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5826). Discussion ---------- "setup" is a noun or adjective, "set up" is the verb Also, I don´t see any need for this to be capitalized Commits ------- 909fab2 Fix title underlining 5c1b3d4 Update title capitalization 50c7010 Changed to title capitalization ece53b8 "setup" is a noun or adjective, "set up" is the verb
Also, I don´t see any need for this to be capitalized