Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"setup" is a noun or adjective, "set up" is the verb #5826

Closed

Conversation

carlos-granados
Copy link

Also, I don´t see any need for this to be capitalized

Also, I don´t see any need for this to be capitalized
@carlos-granados
Copy link
Author

I intended to merge this with branch 2.3, not sure what I did wrong

@javiereguiluz
Copy link
Member

👍 for the fixed typo.

Regarding the title case, Symfony uses a very strange title case variant which is mentioned here (http://symfony.com/doc/current/contributing/documentation/standards.html#english-language-standards). My guess is that this title:

How to set up before and after Filters

Should be spelled instead as:

How to Set Up Before and After Filters

@carlos-granados
Copy link
Author

@javiereguiluz You are right about these weird english capitalization rules, changed to what you suggested

@xabbuh
Copy link
Member

xabbuh commented Oct 22, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Oct 22, 2015

Actually, aren't "before" and "after" closed class words and need to be lowercased?

@carlos-granados
Copy link
Author

Maybe you are right... what about "up"? Probably it should not be uppercase either.
OMG this is turning more complicated than what it sounded :-)

@xabbuh
Copy link
Member

xabbuh commented Oct 23, 2015

I am always confused about this rule too. :) Though I think "Up" should be uppercased as it is part of the verb.

@xabbuh
Copy link
Member

xabbuh commented Oct 26, 2015

@GuGuss Is there an issue with our service hook or is there some other thing going wrong with our platform.sh integration?

@carlos-granados
Copy link
Author

I found these pages with rules for capitalization:

http://www.grammarcheck.net/capitalization-in-titles-101/
http://web.archive.org/web/20130117225252/http://writersblock.ca/tips/monthtip/tipmar98.htm

According to them the capitalization is correct now

@GuGuss
Copy link

GuGuss commented Oct 27, 2015

@xabbuh You're right this time ;) PRs aren't built anymore. I'll check what's happening.

@weaverryan
Copy link
Member

Thanks Carlos! This works for me!

weaverryan added a commit that referenced this pull request Nov 5, 2015
…los-granados)

This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5826).

Discussion
----------

"setup" is a noun or adjective, "set up" is the verb

Also, I don´t see any need for this to be capitalized

Commits
-------

909fab2 Fix title underlining
5c1b3d4 Update title capitalization
50c7010 Changed to title capitalization
ece53b8 "setup" is a noun or adjective, "set up" is the verb
@weaverryan weaverryan closed this Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants