Clarified ambiguous wording #5849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this context, "even" can be misunderstood as "actually".
| @@ -87,7 +87,7 @@ Anonymous function can be used to filter with more complex criteria:: | |||
| $crawler = $crawler | |||
| ->filter('body > p') | |||
| ->reduce(function (Crawler $node, $i) { | |||
| // filter even nodes | |||
| // filter every second node | |||
There was a problem hiding this comment.
What about "filter every other node"?
|
👍 @ThomasLandauer thanks for this small but nice improvement! |
|
👍 |
|
Thanks Thomas! I've merged this into the 2.3 branch. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this context, "even" can be misunderstood as "actually".