-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fortrabbit deployment guide + index listing #6291
Conversation
@ostark the syntax of your article is mostly right. However, we need lines to be wrapped at around 80 characters (we don't use "soft wraps" at the Symfony docs). Thanks! |
@javiereguiluz Thanks for letting me know. |
Environment Variables | ||
~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
Set the `SYMFONY_ENV` environment variable to `prod` to make sure the right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a minor syntax issue here. In Markdown you use 1 backtick, but in RST files you need 2 backticks:
`SYMFONY_ENV` ... `prod`
should be:
``SYMFONY_ENV`` ... ``prod``
Although I don't have experience with fortrabbit, the article looked very informative and easy to follow. I've left some minor comments but overall I'm 👍 for including this article. Thanks @ostark. |
Thanks for your efforts! @javiereguiluz will have a look at your suggestions tomorrow. |
Setting up fortrabbit | ||
--------------------- | ||
|
||
Before we begin, you should have done a few things on the fortrabbit side: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We avoid use "I" or "we" in the documentation.
Thank you for your help @xabbuh & @javiereguiluz! |
official fortrabbit `Symfony install guide`_. | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only use one blank line (same applies to several places below).
@ostark Sorry, I didn't have a enough time to finish my review yesterday. I did that now and left some more minor comments. Overall, the article looks very well (I cannot say anything about how that works as I didn't use fortrabbit yet though). |
@xabbuh Thanks again for taking care! I hope I didn't messed up anything. |
👍 |
This guide helps symfony developers getting started on fortrabbit.com.