Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked the Symfony Releases page #6303

Merged
merged 2 commits into from
Mar 17, 2016

Conversation

javiereguiluz
Copy link
Member

I'd like to display the table of Symfony versions in its own Version History section. This change will allow me to add a link to this section from this other page: http://symfony.com/roadmap


If you want to learn more about the timeline of any given Symfony version,
use the online `timeline calculator`_. You can also get all data as a JSON
string via a URL like `https://symfony.com/roadmap.json?version=2.x`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need double backticks here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last sentence seems to be a feature that should documented on the roadmap page, not in this referencing box.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Wouter. A few days ago we changed the http://symfony.com/roadmap page to add a mention to this TIP:

symfony_roadmap

Would you agree if I remove this sentence from the releases.rst page?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Btw, I like the design of the tip sentence!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, makes sense to remove it now.

@wouterj
Copy link
Member

wouterj commented Feb 27, 2016

@javiereguiluz you can also add a pointer without headline:

.. _community-releases-version-table:

==== ===== ====
...

And then use that as anchor. I don't think it's really needed to put the table in a seperate section.

@javiereguiluz
Copy link
Member Author

@wouterj I don't mind either solution, but let's try to fix this soon because the link that points to this non-existent anchor is already published in http://symfony.com/roadmap page:

full_releases

@javiereguiluz
Copy link
Member Author

I've implemented all your recommendations. Thanks!

@wouterj
Copy link
Member

wouterj commented Mar 10, 2016

👍

Whenever an important event related to Symfony versions happens (a version
reaches end of maintenance or a new patch version is released for
instance), you can automatically receive an email notification if you
subscribed on the `roadmap notification`_ page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This links to the same page as the timeline calculator link. Is that intended? What about adding an anchor to the roadmap notificiation box here and to the version checker for the timeline calculator link?

@weaverryan weaverryan merged commit bdfbfa7 into symfony:2.3 Mar 17, 2016
weaverryan added a commit that referenced this pull request Mar 17, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

Tweaked the Symfony Releases page

I'd like to display the table of Symfony versions in its own `Version History` section. This change will allow me to add a link to this section from this other page: http://symfony.com/roadmap

Commits
-------

bdfbfa7 Fixed everything suggested by reviewers
4132c7e Tweaked the Symfony Releases page
@javiereguiluz javiereguiluz deleted the tweak_releases_page branch May 24, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants