Removed info about reducing visibility for private #6363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes no sense to reduce visibility of private methods as soon as it is minimal visibility. I removed this table line in order to not confuse readers.
|
Another option is to mark this table row as 'n/a' and/or add one more annotation 'Not applicable to private methods'. |
|
👍 make sense @symfony/deciders What do you think? |
|
👍 there's no change - just a clarification - I like it! |
|
👍 to remove it |
|
Awesome, thanks Andrey! |
weaverryan
added a commit
that referenced
this pull request
Mar 17, 2016
…khov) This PR was merged into the 2.3 branch. Discussion ---------- Removed info about reducing visibility for private | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a It makes no sense to reduce visibility of private methods as soon as it is minimal visibility. I removed this table line in order to not confuse readers. Commits ------- bc6a898 Removed info about reducing visibility for private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes no sense to reduce visibility of private methods as soon as it is minimal visibility.
I removed this table line in order to not confuse readers.