[book] [validation] Constraints can be applied to an entire class too #6380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Constraints can be applied to a class property (e.g. ``name``) or a public | ||
| getter method (e.g. ``getFullName``). The first is the most common and easy | ||
| Constraints can be applied to a class property (e.g. ``name``), a public | ||
| getter method (e.g. ``getFullName``) or an entire class. The first is the most common and easy |
There was a problem hiding this comment.
The following sentence now doesn't match properly anymore. Can you reword that a bit?
There was a problem hiding this comment.
Can you be more specific @xabbuh ? What is the sentence not matching properly?
There was a problem hiding this comment.
In the following sentence we mention "the first" and "the second" which is not exact anymore as we now have three things (property, method, and class).
sustmi
force-pushed
the
clarify-class-constraints
branch
2 times, most recently
from
62a6805
to
d02b6d1
Compare
|
I updated the commit to mention all three validation targets. |
| to use, but the second allows you to specify more complex validation rules. | ||
| Constraints can be applied to a class property (e.g. ``name``), a public | ||
| getter method (e.g. ``getFullName``) or an entire class. Property constraints | ||
| are the most common and easy to use. Getter constraints allows you to specify |
There was a problem hiding this comment.
[...] constraints allow you [...]
|
👍 This reads good to me. I just left one minor comment, but we can also fix that while merging. |
sustmi
force-pushed
the
clarify-class-constraints
branch
from
d02b6d1
to
0efdda7
Compare
|
The typo is fixed. |
|
Thanks Miroslav, nice PR! |
wouterj
added a commit
that referenced
this pull request
May 27, 2016
…re class too (sustmi) This PR was merged into the 2.3 branch. Discussion ---------- [book] [validation] Constraints can be applied to an entire class too Commits ------- 0efdda7 [book] [validation] Constraints can be applied to an entire class too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.