Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the documentation about the explicit column widths #6437

Closed

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to master (3.1+)
Fixed tickets -

In addition to the rewording, the setColumnWidth() explanation was missing.

@xabbuh
Copy link
Member

xabbuh commented Apr 6, 2016

@javiereguiluz Why not making this change in older branches too?

@OskarStark
Copy link
Contributor

@xabbuh
Copy link
Member

xabbuh commented Apr 12, 2016

Indeed 👍 reads better

by default. You can control the minimum widths via :method:`Symfony\\Component\\Console\\Helper\\Table::setColumnWidths`::
By default the width of the columns is calculated automatically based on their
contents. Use the :method:`Symfony\\Component\\Console\\Helper\\Table::setColumnWidths`
method to set the columns widths explicitly::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

column

@javiereguiluz
Copy link
Member Author

Fixed all the reported issues.

@wouterj wouterj closed this in 8504381 Apr 18, 2016
wouterj added a commit that referenced this pull request Apr 18, 2016
@wouterj
Copy link
Member

wouterj commented Apr 18, 2016

Thanks @javiereguiluz! I've added the missing versionadded directive for these new methods in 8d9acc5

wouterj added a commit to wouterj/symfony-docs that referenced this pull request Apr 20, 2016
…lumn widths (javiereguiluz)

This PR was squashed before being merged into the master branch (closes symfony#6437).

Discussion
----------

Improved the documentation about the explicit column widths

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | master (3.1+)
| Fixed tickets | -

In addition to the rewording, the `setColumnWidth()` explanation was missing.

Commits
-------

88ecd20 Improved the documentation about the explicit column widths
wouterj added a commit that referenced this pull request Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants