Use different placeholders in mailer config #6452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The placeholders 'AWS_ACCESS_KEY' and 'AWS_SECRET_KEY' are misleading, given that the AWS documentation explicitly states: "Your SMTP user name and password are not the same as your AWS access key ID and secret access key. Do not attempt to use your AWS credentials to authenticate yourself to the Amazon SES SMTP endpoint." Source: http://docs.aws.amazon.com/ses/latest/DeveloperGuide/get-smtp-credentials.html
|
👍 A quick win and a nice improvement. Thanks @sblaut |
|
Good catch, thanks @sblaut. |
xabbuh
added a commit
that referenced
this pull request
Apr 11, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6452). Discussion ---------- Use different placeholders in mailer config The placeholders 'AWS_ACCESS_KEY' and 'AWS_SECRET_KEY' are misleading, given that the AWS documentation explicitly states: "Your SMTP user name and password are not the same as your AWS access key ID and secret access key. Do not attempt to use your AWS credentials to authenticate yourself to the Amazon SES SMTP endpoint." Source: http://docs.aws.amazon.com/ses/latest/DeveloperGuide/get-smtp-credentials.html Commits ------- ba047f1 Use different placeholders in mailer config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The placeholders 'AWS_ACCESS_KEY' and 'AWS_SECRET_KEY' are misleading, given that the AWS documentation explicitly states:
"Your SMTP user name and password are not the same as your AWS access key ID and secret access key. Do not attempt to use your AWS credentials to authenticate yourself to the Amazon SES SMTP endpoint."
Source: http://docs.aws.amazon.com/ses/latest/DeveloperGuide/get-smtp-credentials.html