Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] add support for prioritizing form type extension tags #6958

Closed
wants to merge 2 commits into from

Conversation

dmaicher
Copy link
Contributor

@dmaicher dmaicher commented Sep 9, 2016

@HeahDude
Copy link
Contributor

HeahDude commented Sep 9, 2016

Looks good! Thanks :)

defaults to ``0`` and it controls the order in which the form
type extensions are loaded (the higher the priority, the earlier
an extension is loaded). This is useful when you need to guarantee
that one extensions is loaded before or after another extension.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- that one extensions
+ that one extension

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fabpot added a commit to symfony/symfony that referenced this pull request Sep 14, 2016
…pe extension tags (dmaicher)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[FrameworkBundle] add support for prioritizing form type extension tags

| Q             | A
| ------------- | ---
| Branch?       | "master"
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19735
| License       | MIT
| Doc PR        | symfony/symfony-docs#6958

This PR proposes to add support for `priority` on `form.type_extension` dependecyinjection tags to enable sorting/prioritizing form type extensions.

Issue was mentioned here: #19735

Commits
-------

a3db5f0 [FrameworkBundle] add support for prioritizing form type extension tags
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Sep 14, 2016
…pe extension tags (dmaicher)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[FrameworkBundle] add support for prioritizing form type extension tags

| Q             | A
| ------------- | ---
| Branch?       | "master"
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19735
| License       | MIT
| Doc PR        | symfony/symfony-docs#6958

This PR proposes to add support for `priority` on `form.type_extension` dependecyinjection tags to enable sorting/prioritizing form type extensions.

Issue was mentioned here: symfony/symfony#19735

Commits
-------

a3db5f0 [FrameworkBundle] add support for prioritizing form type extension tags
@xabbuh
Copy link
Member

xabbuh commented Sep 22, 2016

We should add a versionadded directive for this.

Status: Reviewed

@javiereguiluz
Copy link
Member

👍

@xabbuh
Copy link
Member

xabbuh commented Oct 26, 2016

Thank you @dmaicher.

@xabbuh xabbuh closed this in c2e58d5 Oct 26, 2016
xabbuh added a commit that referenced this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants