[HttpFoundation] Add doc for File\Stream #7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Jan 9, 2017
nicolas-grekas
force-pushed
the
bin-stream
branch
from
a1aaae3
to
a6f41f5
Compare
OskarStark
approved these changes
Jan 9, 2017
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 9, 2017
…ryFileResponse (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpFoundation] Add File\Stream for size-unknown BinaryFileResponse | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19738 | License | MIT | Doc PR | symfony/symfony-docs#7343 Replaces #19740. Native "getSize" is reported to return false on error, so using false as return type doesn't break the signature. Commits ------- 8011209 [HttpFoundation] Add File\Stream for size-unknown BinaryFileResponse
symfony-splitter
pushed a commit
to symfony/http-foundation
that referenced
this pull request
Jan 9, 2017
…ryFileResponse (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpFoundation] Add File\Stream for size-unknown BinaryFileResponse | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19738 | License | MIT | Doc PR | symfony/symfony-docs#7343 Replaces #19740. Native "getSize" is reported to return false on error, so using false as return type doesn't break the signature. Commits ------- 8011209a18 [HttpFoundation] Add File\Stream for size-unknown BinaryFileResponse
xabbuh
added a commit
that referenced
this pull request
Jan 10, 2017
This PR was merged into the master branch. Discussion ---------- [HttpFoundation] Add doc for File\Stream Commits ------- a6f41f5 [HttpFoundation] Add doc for File\Stream
xabbuh
added a commit
that referenced
this pull request
Jan 10, 2017
|
Thank you Nicolas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.