Add Lock's PdoStore documentation #9875

jderusse · 2018-06-04T08:44:30Z

OskarStark · 2018-08-12T20:10:56Z

components/lock.rst

@@ -195,7 +196,7 @@ PHP process is terminated::

    Beware that some file systems (such as some types of NFS) do not support
    locking. In those cases, it's better to use a directory on a local disk
-    drive or a remote store based on Redis or Memcached.
+    drive or a remote store based on Pdo, Redis or Memcached.


OskarStark · 2018-08-12T20:12:54Z

components/lock.rst

+.. caution::
+
+    In a cluster configured with multiple master, ensure writes are
+    synchronously propaged to every nodes, or always use the same node.


propagated?

OskarStark · 2018-08-12T20:14:05Z

components/lock.rst

+
+In order to purge old lock, this store use a current datetime to define a
+expiration date reference. This mechanism relies on all client and server nodes
+to have synchronized clock.


I read the code PR, is a synchronized clock still needed?

Good catch! indeed a previous version uses the client's clock. But it has been replaced by SGDB's time.

I removed the client from the sentence, as this is still the case for multi-master nodes

fabpot · 2018-09-04T10:07:57Z

components/lock.rst

+
+    use Symfony\Component\Lock\Store\PdoStore;
+
+


extra blank line

fabpot · 2018-09-04T10:08:24Z

components/lock.rst

+PdoStore
+~~~~~~~~~~
+
+The PdoStore rely on the `ACID`_ properties of the SQL engine.


fabpot · 2018-09-04T10:08:31Z

components/lock.rst

+
+.. caution::
+
+    In a cluster configured with multiple master, ensure writes are


multiple masters

fabpot · 2018-09-04T10:08:51Z

components/lock.rst

+
+.. caution::
+
+    Some SQL engine like MySQL allows to disable unique constraint check.


SQL engines ... allow ... disable the unique ...

fabpot · 2018-09-04T10:09:10Z

components/lock.rst

+    Some SQL engine like MySQL allows to disable unique constraint check.
+    Ensure that this is not the case ``SET unique_checks=1;``.
+
+In order to purge old lock, this store use a current datetime to define a


old locks, this store uses

an expiration

fabpot · 2018-09-04T10:09:25Z

components/lock.rst

+
+In order to purge old lock, this store use a current datetime to define a
+expiration date reference. This mechanism relies on all server nodes to
+have synchronized clock.


fabpot · 2018-09-04T10:09:33Z

components/lock.rst

+
+.. caution::
+
+    To ensure locks don't expire prematurely; the ttl's should be set with


fabpot · 2018-09-04T10:09:59Z

components/lock.rst

-``Lock``, therefore this key must not be shared between processes (session,
+Remote stores (:ref:`MemcachedStore <lock-store-memcached>`,
+:ref:`PdoStore <lock-store-pdo>` and :ref:`RedisStore <lock-store-redis>`) use
+an unique token to recognize the true owner of the lock. This token is stored


This PR was merged into the 4.2-dev branch. Discussion ---------- [LOCK] Add a PdoStore | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25400 | License | MIT | Doc PR | symfony/symfony-docs#9875 This is an alternative to #25578 Commits ------- 46fe1b0712 Add a PdoStore in lock

This PR was merged into the 4.2-dev branch. Discussion ---------- [LOCK] Add a PdoStore | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25400 | License | MIT | Doc PR | symfony/symfony-docs#9875 This is an alternative to #25578 Commits ------- 46fe1b0 Add a PdoStore in lock

jderusse · 2018-09-04T17:13:20Z

components/lock.rst

+
+.. caution::
+
+    In a cluster configured with multiple masters, ensure writes are


Is it correct to use the word master (in the context master/slave database)?

ping @lsmith77 or @javiereguiluz

cf: redis/redis#3185

master/slave is a bad terminology (see https://twitter.com/dhh/status/1032268675674296320)

yes, that's exactly my question, replaced by primaries

javiereguiluz · 2018-09-07T13:44:20Z

Thanks for contributing these docs Jérémy! They are merged now in time to prepare for Symfony 4.2 update. Thanks!

Add Lock's PdoStore documentation

112db87

carsonbot added the Status: Needs Review label Jun 4, 2018

jderusse mentioned this pull request Jun 4, 2018

[LOCK] Add a PdoStore symfony/symfony#27456

Merged

xabbuh added the Waiting Code Merge Docs for features pending to be merged label Aug 7, 2018

OskarStark reviewed Aug 12, 2018

View reviewed changes

Add verisonAdded

2a7923b

jderusse force-pushed the lock-pdo branch from ac42edc to 2a7923b Compare August 13, 2018 09:29

fabpot requested changes Sep 4, 2018

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Sep 4, 2018

carsonbot added Status: Needs Review and removed Status: Needs Work labels Sep 4, 2018

jderusse commented Sep 4, 2018

View reviewed changes

Fix typo

ac621e5

jderusse force-pushed the lock-pdo branch from c242be5 to ac621e5 Compare September 4, 2018 17:20

javiereguiluz added Lock and removed Waiting Code Merge Docs for features pending to be merged labels Sep 7, 2018

javiereguiluz added this to the 4.2 milestone Sep 7, 2018

javiereguiluz closed this in 58e4446 Sep 7, 2018

jderusse deleted the lock-pdo branch April 18, 2020 10:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Lock's PdoStore documentation #9875

Add Lock's PdoStore documentation #9875

jderusse commented Jun 4, 2018

OskarStark Aug 12, 2018

OskarStark Aug 12, 2018

OskarStark Aug 12, 2018

jderusse Aug 13, 2018

fabpot Sep 4, 2018

fabpot Sep 4, 2018

fabpot Sep 4, 2018

fabpot Sep 4, 2018

fabpot Sep 4, 2018

fabpot Sep 4, 2018

fabpot Sep 4, 2018

fabpot Sep 4, 2018

fabpot Sep 4, 2018

jderusse Sep 4, 2018 •

edited

Loading

fabpot Sep 4, 2018

jderusse Sep 4, 2018

javiereguiluz commented Sep 7, 2018


		.. caution::

		In a cluster configured with multiple master, ensure writes are


		.. caution::

		Some SQL engine like MySQL allows to disable unique constraint check.


		.. caution::

		To ensure locks don't expire prematurely; the ttl's should be set with

Add Lock's PdoStore documentation #9875

Add Lock's PdoStore documentation #9875

Conversation

jderusse commented Jun 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jderusse Sep 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

javiereguiluz commented Sep 7, 2018

jderusse Sep 4, 2018 •

edited

Loading