[Validator] Fixed ACE domain checks on UrlValidator (#10031) #10275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis's failure has nothing to do with this PR, apparently... |
fabpot
added a commit
that referenced
this pull request
Mar 26, 2014
… (aeoris) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Fixed ACE domain checks on UrlValidator (#10031) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10031 | License | MIT | Doc PR | I added some checks to allow internationalised domain names as per reported on #10031 and some extra testcases to cover ACE domain names. Commits ------- 7a2f154 Fixed ACE domain checks on UrlValidator (#10031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some checks to allow internationalised domain names as per reported on #10031 and some extra testcases to cover ACE domain names.