[2.3][Validator] Minor fix in IBAN validator #10494
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| )); | ||
|
|
||
| $this->validator->validate($iban, $constraint); | ||
| } |
There was a problem hiding this comment.
Due to do something I tried before. Undoing it.
fabpot
added a commit
that referenced
this pull request
Mar 19, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [2.3][Validator] Minor fix in IBAN validator | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10481, #10489 | License | MIT Added more values to unit tests of IBAN validator to make clear it doesn't accept lower case letters. > Permitted IBAN characters are the digits 0 to 9 and the 26 upper-case Latin alphabetic characters A to Z. http://en.wikipedia.org/wiki/International_Bank_Account_Number Also made little adjustment to code which meant to validate lowercase letters but actually was useless. Commits ------- 3eeb306 Fix IBAN validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more values to unit tests of IBAN validator to make clear it doesn't accept lower case letters.
Also made little adjustment to code which meant to validate lowercase letters but actually was useless.