[TwigBundle] do not pass a template reference to twig #12197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twig does not know about template references and only expects a string. this commit also fixes that name parsing and locating was called twice for nonexistent templates
| */ | ||
| public function exists($template) | ||
| public function exists($name) |
There was a problem hiding this comment.
this change makes it consistent with newer branches, so it applies cleanly
|
👍 |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2014
…ion) This PR was merged into the 2.3 branch. Discussion ---------- [TwigBundle] do not pass a template reference to twig | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - twig does not know about template references and only expects a string. this commit also fixes that name parsing and locating was called twice for nonexistent templates. Commits ------- 7fe33e3 [TwigBundle] do not pass a template reference to twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twig does not know about template references and only expects a string.
this commit also fixes that name parsing and locating was called twice for nonexistent templates.