[Routing] fix BC #12397
Merged
[Routing] fix BC #12397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Are you sure that this change is necessary (the code has been the same since its initial commit, hasn't it?)? The tests that I see are failing, do fail because of the missing Finder component (see #12398 for a fix). |
|
Sure: see https://travis-ci.org/symfony/symfony/builds/39832453 |
|
Oh, yes you're right. The test was introduced in #12329 in the 2.3 branch. |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 3, 2014
This PR was merged into the 2.5 branch. Discussion ---------- [Routing] fix BC | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Tests on master and 2.5 are failing because this patch is missing. Commits ------- 86e667b [Routing] fix BC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests on master and 2.5 are failing because this patch is missing.