[DoctrineBridge] Fixed #14840 #14841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug with Phars, `realpath` and mapping driver config setter in `Symfony\Bridge\Doctrine\DependencyInjection\AbstractDoctrineExtension`
| throw new \InvalidArgumentException(sprintf('Invalid Doctrine mapping path given. Cannot load Doctrine mapping/bundle named "%s".', $mappingName)); | ||
| } | ||
|
|
||
| $this->drivers[$mappingConfig['type']][$mappingConfig['prefix']] = realpath($mappingConfig['dir']); | ||
| if (strpos($mappingDirectory, 'phar://') === false) { |
There was a problem hiding this comment.
it should only look at the beginning of the string, not anywhere
Somehow optimized the solution.
|
I am being sent these random issues via code triage. Is there anything to help with on this one or is it just basically waiting to be merged? |
|
@danielrose28 It just needs to be merged, bug was really small. |
|
@saksmt Cool. Just wanted to see if there was anything I could do. Thanks. |
|
Thank you @saksmt. |
fabpot
added a commit
that referenced
this pull request
Sep 14, 2015
This PR was squashed before being merged into the 2.3 branch (closes #14841). Discussion ---------- [DoctrineBridge] Fixed #14840 [DoctrineBridge] Fixed compatibility with entities packed in Phar | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14840 | License | MIT | Doc PR | none Commits ------- 92ad5df [DoctrineBridge] Fixed #14840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DoctrineBridge] Fixed compatibility with entities packed in Phar