[ExpressionLanguage] Fixed expressions cache key generation #15552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2015 15:56
|
LGTM. |
inso
changed the title
|
ping @symfony/deciders |
|
👍 Status: Reviewed |
|
Thank you @inso. |
fabpot
added a commit
that referenced
this pull request
Sep 7, 2015
…n (inso) This PR was squashed before being merged into the 2.7 branch (closes #15552). Discussion ---------- [ExpressionLanguage] Fixed expressions cache key generation | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Reworked version of #15537 Difference with original PR: - sort $names array to ensure its order does not affect caching, added test for it - minor tweaks for cache key format - used `foreach` instead of `array_map` P.S. I'm not proficient with tests so not sure if tests are correct. Commits ------- 4114a2b [ExpressionLanguage] Fixed expressions cache key generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked version of #15537
Difference with original PR:
foreachinstead ofarray_mapP.S. I'm not proficient with tests so not sure if tests are correct.