Add appveyor.yml for C.I. on Windows #15575

nicolas-grekas · 2015-08-18T14:06:50Z

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	YES, both on Travis (Linux) and on Appveyor (Windows)!
Fixed tickets	#13934, #15049, #14259, #15045, #15444
License	MIT
Doc PR	symfony/symfony-docs#5654

testing two matrix lines:
- one without mbtring nor fileinfo nor intl
- one with these ext enables, intl version 51.2 so that almost no test is skipped on our Intl component
bug fixes thanks to these harder testing conditions
some display bug on appveyor, reported here.

stof · 2015-08-18T14:49:53Z

should we also try compiling the debug extension on Windows ? Or should we wait until we decide whether we move it to a separate repo ?
In any case, it is irrelevant for 2.3 as it does not have the C extension

stof · 2015-08-18T14:50:28Z

appveyor.yml

+  - php composer.phar install --prefer-dist --no-interaction
+test_script:
+  - cd C:\projects\symfony
+  - php -r "readfile('https://phar.phpunit.de/phpunit.phar');" | php


what about using native ways to download files instead ? http://www.appveyor.com/docs/how-to/download-file

btw, this is already done for the php.zip file.

and downloading phpunit should also be part of the installation rather than the tests

Because I'd prefer having commands read/writables by us. And also because cakephp does this way :)

but the current comment could have issues. see https://github.com/symfony/symfony-installer/issues/137

nicolas-grekas · 2015-08-18T15:18:26Z

That would be great to have the debug ext compiled also, but let's first make this one work.

fabpot · 2015-08-18T15:22:18Z

Account has been created now. Try to push here to trigger a new build as I don't seem to have any way to do that from the interface.

nicolas-grekas · 2015-08-18T15:57:34Z

@fabpot thanks, did you setup the webhook?
Here is a helper screenshot for PR support:

stof · 2015-08-18T16:47:24Z

appveyor.yml

+  - echo extension=php_mbstring.dll >> php.ini
+  - echo extension=php_fileinfo.dll >> php.ini
+  - php -r "readfile('https://getcomposer.org/installer');" | php
+  - echo @php c:\php\composer.phar %*>composer.bat


your composer bat file does not work

nicolas-grekas · 2015-08-18T17:04:34Z

The build is now working! But phpunit crashes before going to the end of the test suite :(
Any Windows expert here?

stof · 2015-08-18T17:15:07Z

appveyor.yml

+  - php c:\php\composer.phar install --prefer-dist --no-progress
+  - mkdir phpunit
+  - cd phpunit
+  - ps: Start-FileDownload 'https://github.com/sebastianbergmann/phpunit/archive/4.7.zip'


the current stable version of PHPUnit is 4.8, not 4.7

stof · 2015-08-18T17:16:08Z

@nicolas-grekas can you try running the testsuite in smaller chunks (component by component) to see whether it helps ? We are not running the full testsuite in 1 go on Travis (even though the main goal was to parallelize runs to be faster)

nicolas-grekas · 2015-08-18T17:19:23Z

If you give me the command to do so, yes :)

nicolas-grekas · 2015-08-18T21:00:42Z

Any PowerShell scripter here? We would need a ps script to run phpunit tests in parallel, the same as we do on unixes with find src/Symfony -mindepth 3 -type f -name phpunit.xml.dist -printf '%h\n' | parallel --gnu --keep-order 'echo -e "\\nRunning {} tests"; php --exclude-group tty,benchmark,intl-data {} || (echo "KO {}" && $(exit 1));'

Invole-Parallel could maybe help, but I must admit I'm a total noob here.

nicolas-grekas · 2015-08-18T21:08:28Z

An other idea could be to run bash from cygwin, it's maybe even already somewhere on the vm.

wouterj · 2015-08-18T21:18:00Z

@nicolas-grekas I have both powershell and cygwin on my PC, what do you want me to do/try?

nicolas-grekas · 2015-08-25T13:26:00Z

Status: needs review
Except for a transient test on the Process component, tests are green.

nicolas-grekas · 2015-08-25T13:36:25Z

src/Symfony/Component/Intl/Tests/DateFormatter/AbstractIntlDateFormatterTest.php

@@ -38,11 +38,16 @@ public function testConstructorDefaultTimeZone()
        $formatter = $this->getDateFormatter('en', IntlDateFormatter::MEDIUM, IntlDateFormatter::SHORT);

        // In PHP 5.5 default timezone depends on `date_default_timezone_get()` method
-        if (PHP_VERSION_ID >= 50500) {
+        if (PHP_VERSION_ID >= 50500 || (extension_loaded('intl') && method_exists('IntlDateFormatter', 'setTimeZone'))) {


pecl intl 3.0 backports php5.5 behavior to 5.3/5.4

nicolas-grekas · 2015-08-25T15:28:11Z

src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php

@@ -568,8 +570,16 @@ public function setTimeZoneId($timeZoneId)

        try {
            $this->dateTimeZone = new \DateTimeZone($timeZoneId);
+            if ('GMT' !== $timeZoneId && $this->dateTimeZone->getName() !== $timeZoneId) {


Some invalid timezones are accepted by DateTimeZone since 5.5.10, but rejected by IntlDateFormatter.

nicolas-grekas · 2015-08-25T16:59:16Z

ping @symfony/deciders , especially @webmozart

fabpot · 2015-08-26T08:48:44Z

Not mergeable yet as there is still a failing test on Windows.

fabpot · 2015-08-26T09:00:32Z

Thank you @nicolas-grekas.

This PR was merged into the 2.3 branch. Discussion ---------- Add appveyor.yml for C.I. on Windows | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | YES, both on Travis (Linux) and on Appveyor (Windows)! | Fixed tickets | #13934, #15049, #14259, #15045, #15444 | License | MIT | Doc PR | symfony/symfony-docs#5654 - testing two matrix lines: - one without mbtring nor fileinfo nor intl - one with these ext enables, intl version 51.2 so that almost no test is skipped on our Intl component - bug fixes thanks to these harder testing conditions - some display bug on appveyor, [reported here](http://help.appveyor.com/discussions/suggestions/197-support-ansi-color-codes). Commits ------- ea5d656 Windows and Intl fixes 8bbd8d9 Add appveyor.yml for C.I. on Windows

stof · 2015-08-26T10:08:09Z

appveyor.yml

+install:
+    - IF EXIST c:\php (SET PHP=0) ELSE (mkdir c:\php)
+    - cd c:\php
+    - IF %PHP%==1 appveyor DownloadFile http://windows.php.net/downloads/releases/archives/php-5.4.43-nts-Win32-VC9-x86.zip


@nicolas-grekas why testing against PHP 5.4 which is nearly EOL rather than against PHP 5.6 ?

because I couldn't find a .dll for intl + icu 51.2 for 5.5 (vc9-nts-x86)

This PR was merged into the 2.3 branch. Discussion ---------- Doc about new way of running tests | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | all | Fixed tickets | - Related to symfony/symfony#15575 Commits ------- dc754c8 Doc about new way of running tests

carsonbot added the Status: Needs Review label Aug 18, 2015

stof reviewed Aug 18, 2015
View reviewed changes

nicolas-grekas added Status: Needs Work and removed Status: Needs Review labels Aug 18, 2015

nicolas-grekas force-pushed the appveyor branch from d252957 to c658d49 Compare August 18, 2015 15:25

nicolas-grekas force-pushed the appveyor branch 3 times, most recently from 2197a23 to 32932f5 Compare August 18, 2015 16:32

stof reviewed Aug 18, 2015
View reviewed changes

nicolas-grekas force-pushed the appveyor branch 3 times, most recently from 7b474b0 to 646b0db Compare August 18, 2015 17:03

stof reviewed Aug 18, 2015
View reviewed changes

nicolas-grekas force-pushed the appveyor branch from 646b0db to 37e1d49 Compare August 18, 2015 17:18

nicolas-grekas force-pushed the appveyor branch from 37e1d49 to 0526ee8 Compare August 18, 2015 20:44

nicolas-grekas force-pushed the appveyor branch from 0526ee8 to 5d461b9 Compare August 18, 2015 21:02

nicolas-grekas force-pushed the appveyor branch 3 times, most recently from f653ba4 to ccc91e9 Compare August 18, 2015 21:45

carsonbot added Status: Needs Review and removed Status: Needs Work labels Aug 25, 2015

nicolas-grekas added the Ready label Aug 25, 2015

nicolas-grekas force-pushed the appveyor branch 2 times, most recently from e044e77 to aa357f8 Compare August 25, 2015 13:32

nicolas-grekas reviewed Aug 25, 2015
View reviewed changes

nicolas-grekas force-pushed the appveyor branch from aa357f8 to d83ac63 Compare August 25, 2015 15:20

nicolas-grekas reviewed Aug 25, 2015
View reviewed changes

nicolas-grekas force-pushed the appveyor branch from d83ac63 to 6a0d181 Compare August 25, 2015 20:07

nicolas-grekas mentioned this pull request Aug 25, 2015

[travis] make the PHP version check for APC more robust #15616

Closed

nicolas-grekas force-pushed the appveyor branch 3 times, most recently from f01bff8 to 05efbe1 Compare August 25, 2015 21:21

nicolas-grekas added 2 commits August 25, 2015 23:41

Add appveyor.yml for C.I. on Windows

8bbd8d9

Windows and Intl fixes

ea5d656

nicolas-grekas force-pushed the appveyor branch from 05efbe1 to ea5d656 Compare August 25, 2015 21:41

fabpot merged commit ea5d656 into symfony:2.3 Aug 26, 2015

stof reviewed Aug 26, 2015
View reviewed changes

nicolas-grekas deleted the appveyor branch August 26, 2015 11:50

This was referenced Oct 28, 2015

CI AppVeyor dg/texy#38

Closed

CI AppVeyor Sylius/Sylius#3501

Merged

barryvdh mentioned this pull request Feb 22, 2016

Appveyor CI for Windows laravel/framework#12410

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add appveyor.yml for C.I. on Windows #15575

Add appveyor.yml for C.I. on Windows #15575

nicolas-grekas commented Aug 18, 2015

stof commented Aug 18, 2015

stof Aug 18, 2015

stof Aug 18, 2015

nicolas-grekas Aug 18, 2015

stof Aug 18, 2015

nicolas-grekas commented Aug 18, 2015

fabpot commented Aug 18, 2015

nicolas-grekas commented Aug 18, 2015

stof Aug 18, 2015

nicolas-grekas commented Aug 18, 2015

stof Aug 18, 2015

stof commented Aug 18, 2015

nicolas-grekas commented Aug 18, 2015 via email

nicolas-grekas commented Aug 18, 2015

nicolas-grekas commented Aug 18, 2015

wouterj commented Aug 18, 2015

nicolas-grekas commented Aug 25, 2015

nicolas-grekas Aug 25, 2015

nicolas-grekas Aug 25, 2015

nicolas-grekas commented Aug 25, 2015

fabpot commented Aug 26, 2015

fabpot commented Aug 26, 2015

stof Aug 26, 2015

nicolas-grekas Aug 26, 2015

Add appveyor.yml for C.I. on Windows #15575

Add appveyor.yml for C.I. on Windows #15575

Conversation

nicolas-grekas commented Aug 18, 2015

stof commented Aug 18, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas commented Aug 18, 2015

fabpot commented Aug 18, 2015

nicolas-grekas commented Aug 18, 2015

Choose a reason for hiding this comment

nicolas-grekas commented Aug 18, 2015

Choose a reason for hiding this comment

stof commented Aug 18, 2015

nicolas-grekas commented Aug 18, 2015 via email

nicolas-grekas commented Aug 18, 2015

nicolas-grekas commented Aug 18, 2015

wouterj commented Aug 18, 2015

nicolas-grekas commented Aug 25, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas commented Aug 25, 2015

fabpot commented Aug 26, 2015

fabpot commented Aug 26, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment