Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Deprecated TimezoneType::getTimezones() #16687

Merged
merged 1 commit into from
Nov 27, 2015

Conversation

webmozart
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This method is useless as of #16681. It needs to be deprecated before we can remove it since it is public.

@fabpot
Copy link
Member

fabpot commented Nov 26, 2015

It triggers deprecation notices that must be fixed.

@stof
Copy link
Member

stof commented Nov 26, 2015

@fabpot see the description. It depends on a PR not yet merged

@fabpot
Copy link
Member

fabpot commented Nov 27, 2015

Thank you @webmozart.

@fabpot fabpot merged commit 41df3fc into symfony:2.8 Nov 27, 2015
fabpot added a commit that referenced this pull request Nov 27, 2015
…art)

This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Deprecated TimezoneType::getTimezones()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This method is useless as of #16681. It needs to be deprecated before we can remove it since it is public.

Commits
-------

41df3fc [Form] Deprecated TimezoneType::getTimezones()
This was referenced Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants