[TwigBridge] Use label_format option for checkbox and radio labels #17380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
enumag
commented
Jan 14, 2016
enumag
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
👍 Is this the only place where we need to make this change? Status: Reviewed |
|
Not sure I'll take a look at the other files. |
|
@xabbuh Turns out we should do the same in the twig template for foundation 5. However since it is not present in 2.7 I can't include the change in this PR. Should I open a second one? |
|
@enumag Would be great if you were able to do that. 👍 |
|
Ref #12050 for the original PR. 👍 |
|
No that was just for anyone reviewing the code |
|
Thank you @enumag. |
fabpot
added a commit
that referenced
this pull request
Jan 15, 2016
…o labels (enumag) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBridge] Use label_format option for checkbox and radio labels | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- dc8f780 [TwigBridge] Use label_format option for checkbox and radio labels
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.