[HttpFoundation] BinaryFileResponse sendContent return as parent. (2.3) #17757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
Thank you @SpacePossum. |
fabpot
added a commit
that referenced
this pull request
Feb 11, 2016
…parent. (2.3) (SpacePossum) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] BinaryFileResponse sendContent return as parent. (2.3) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT `BinaryFileResponse` extends `Response` and overrides the `sendContent`-method. It would be nice if it also returns as the parent does, i.e. itself. This makes it easier to deal with diff. `Response` classes. The other fixes are to make SCA easier. No BC-breaks AFAIK. Commits ------- 120dfe4 sendContent return as parent.
This was referenced Feb 28, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinaryFileResponseextendsResponseand overrides thesendContent-method. It would be nice if it also returns as the parent does, i.e. itself. This makes it easier to deal with diff.Responseclasses.The other fixes are to make SCA easier. No BC-breaks AFAIK.