Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Fix depreciation triggers #19260

Merged

Conversation

tgalopin
Copy link
Contributor

@tgalopin tgalopin commented Jul 1, 2016

Q A
Branch? 3.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? -
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This adds a missing E_USER_DEPRECATED in a trigger_error.

@HeahDude
Copy link
Contributor

HeahDude commented Jul 1, 2016

Wow, good catch! Thanks 👍

Status: Reviewed

@tgalopin tgalopin changed the title [Doctrine] Fix depreciation in Form DoctrineChoiceLoader [Form] Fix depreciation triggers Jul 1, 2016
@tgalopin tgalopin force-pushed the fix-depreciation-doctrine-choice branch from 313450c to deb12ae Compare July 1, 2016 14:52
@HeahDude
Copy link
Contributor

HeahDude commented Jul 1, 2016

👍

@nicolas-grekas
Copy link
Member

Thank you @tgalopin.

@nicolas-grekas nicolas-grekas merged commit deb12ae into symfony:3.1 Jul 1, 2016
nicolas-grekas added a commit that referenced this pull request Jul 1, 2016
This PR was merged into the 3.1 branch.

Discussion
----------

[Form] Fix depreciation triggers

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | -
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This adds a missing `E_USER_DEPRECATED` in a `trigger_error`.

Commits
-------

deb12ae [Form] Fix depreciation triggers
@tgalopin tgalopin deleted the fix-depreciation-doctrine-choice branch July 1, 2016 15:06
@fabpot fabpot mentioned this pull request Jul 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants