fixed Filesystem:makePathRelative and added 2 more testcases #19478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This explains the bug a bit more: #19482 |
|
👍 Status: Reviewed |
|
@muhammedeminakbulut Shouldn't this be fixed in Symfony 2.7 too? |
|
@xabbuh I did not check 2.7 for this bug. 2.7 was out of my scope then |
|
👍 |
|
Thank you @muhammedeminakbulut. |
fabpot
added a commit
that referenced
this pull request
Oct 14, 2016
…es (muhammedeminakbulut) This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #19478). Discussion ---------- fixed Filesystem:makePathRelative and added 2 more testcases | Q | A | ------------- | --- | Branch? |2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT The 2 new test cases where broken on the old code. The old testcases and the new one succeed with the given code. Commits ------- cd3206c fixed Filesystem:makePathRelative and added 2 more testcases
This was referenced Oct 27, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2 new test cases where broken on the old code. The old testcases and the new one succeed with the given code.