[Debug] ensured that a fatal PHP error is actually fatal after being handled by our error handler #9648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handled by our error handler
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| use Symfony\Component\Debug\Exception\FatalErrorException; | |||
There was a problem hiding this comment.
should this be ordered alphabetically? or is just more or less ok?
There was a problem hiding this comment.
we don't reorder existing use statements, to avoid useless conflicts when merging maintenance branches into newer branches
fabpot
added a commit
that referenced
this pull request
Nov 28, 2013
…ter being handled by our error handler (fabpot) This PR was merged into the 2.3 branch. Discussion ---------- [Debug] ensured that a fatal PHP error is actually fatal after being handled by our error handler This is a follow-up for #9641 where I try to restore the previous code behavior as much as possible. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- d7a4cfb [Debug] ensured that a fatal PHP error is actually fatal after being handled by our error handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #9641 where I try to restore the previous code behavior as much as possible.