Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read validation contraints from Resources/config/validation/ sub-dir #13855

Merged
merged 1 commit into from
Mar 9, 2015

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Mar 5, 2015

When a bundle contains many entities/documents and it uses YAML or XML format instead of annotations, it is convenient to split the validation constraints into several small files.

With this simple PR, every files in the validation sub-directory will be loaded by the validator like it's done for doctrine mapping.

Resources/
    config/
        doctrine/
            Author.orm.yml
            Post.orm.yml
        validation/
            Author.yml
            Post.yml
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets How to split validation yaml files
License MIT
Doc PR symfony/symfony-docs#5060

Read more: http://blog.kevingomez.fr/2013/10/14/split-symfony2-yaml-validation-configuration-file/

@GromNaN GromNaN changed the title Read validation contraints from Resources/config/validation/ dir Read validation contraints from Resources/config/validation/ sub-dir Mar 5, 2015
@wouterj
Copy link
Member

wouterj commented Mar 7, 2015

👍

@fabpot
Copy link
Member

fabpot commented Mar 9, 2015

Thank you @GromNaN.

@fabpot fabpot merged commit e41dcb3 into symfony:2.7 Mar 9, 2015
fabpot added a commit that referenced this pull request Mar 9, 2015
…ation/ sub-dir (GromNaN)

This PR was merged into the 2.7 branch.

Discussion
----------

Read validation contraints from Resources/config/validation/ sub-dir

When a bundle contains many entities/documents and it uses YAML or XML format instead of annotations, it is convenient to split the validation constraints into several small files.

With this simple PR, every files in the `validation` sub-directory will be loaded by the validator like it's done for doctrine mapping.

```
Resources/
    config/
        doctrine/
            Author.orm.yml
            Post.orm.yml
        validation/
            Author.yml
            Post.yml
```

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | [How to split validation yaml files](http://stackoverflow.com/questions/24064813/how-to-split-validation-yaml-files-in-symfony-2-5/24210501#24210501)
| License       | MIT
| Doc PR        | symfony/symfony-docs#5060

Read more: http://blog.kevingomez.fr/2013/10/14/split-symfony2-yaml-validation-configuration-file/

Commits
-------

e41dcb3 [FrameworkBundle] Read config/validation/*.(xml|yml) files
@GromNaN GromNaN deleted the validation-dir branch March 9, 2015 11:50
wouterj added a commit to symfony/symfony-docs that referenced this pull request Apr 2, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

Adds note on new validation files scanned in 2.7

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes (symfony/symfony#13855)
| Applies to    | 2.7
| Fixed tickets | -

Commits
-------

0967d07 Adds note on new validation files scanned in 2.7
JMLamodiere added a commit to Linkvalue-Interne/MajoraFrameworkExtraBundle that referenced this pull request Oct 21, 2016
Reading sub-dir of Resources/config/validation/ is already done in symfony FrameworkBundle since 2.7
Will lead to including yaml validation files twice, and applying validations twice

See symfony/symfony#13855
JMLamodiere added a commit to Linkvalue-Interne/MajoraFrameworkExtraBundle that referenced this pull request Oct 21, 2016
Reading sub-dir of Resources/config/validation/ is already done in symfony FrameworkBundle since 2.7
Will lead to including yaml validation files twice, and applying validations twice

See symfony/symfony#13855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants