Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Finder] Deprecate FilterIterator #22828

Merged
merged 1 commit into from
May 21, 2017
Merged

[Finder] Deprecate FilterIterator #22828

merged 1 commit into from
May 21, 2017

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? 3.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #22820 (review)
License MIT
Doc PR N/A

@ogizanagi ogizanagi mentioned this pull request May 21, 2017
Closed
@nicolas-grekas
Copy link
Member

That's for 3.4

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone May 21, 2017
@ogizanagi ogizanagi changed the base branch from 3.3 to 3.4 May 21, 2017 12:13
@ogizanagi
Copy link
Contributor Author

Oops, indeed. Rebased & re-targeted.

nicolas-grekas
nicolas-grekas approved these changes May 21, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolas-grekas
Copy link
Member

The corresponding test case should be marked as legacy

@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 946066c into symfony:3.4 May 21, 2017
nicolas-grekas added a commit that referenced this pull request May 21, 2017
@nicolas-grekas
feature #22828 [Finder] Deprecate FilterIterator (ogizanagi)
08aa6a8 
This PR was merged into the 3.4 branch.

Discussion
----------

[Finder] Deprecate FilterIterator

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #22820 (review)
| License       | MIT
| Doc PR        | N/A

Commits
-------

946066c [Finder] Deprecate FilterIterator
@ogizanagi ogizanagi deleted the deprec/finder/filter_iterator branch May 21, 2017 17:38
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ogizanagi @nicolas-grekas