New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix missing unset leading to false-positive circular ref #25313

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 4, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25044
License MIT
Doc PR -
@fabpot

fabpot approved these changes Dec 4, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 4, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented Dec 4, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 17d84f6 into symfony:3.4 Dec 4, 2017

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Dec 4, 2017

bug #25313 [DI] Fix missing unset leading to false-positive circular …
…ref (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix missing unset leading to false-positive circular ref

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25044
| License       | MIT
| Doc PR        | -

Commits
-------

17d84f6 [DI] Fix missing unset leading to false-positive circular ref

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-unload branch Dec 4, 2017

This was referenced Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment