[Validator] Feature #36362 add Isin validator constraint #36368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmasforne
changed the title
OskarStark
reviewed
Apr 13, 2020
YaFou
suggested changes
Apr 16, 2020
Feature #36362 typo Fix PR feedbacks Fix coding standard ticket 36362 fix PR feedbacks Update src/Symfony/Component/Validator/Constraints/IsinValidator.php Co-Authored-By: Yannis Foucher <33806646+YaFou@users.noreply.github.com>
YaFou
approved these changes
Apr 17, 2020
xabbuh
reviewed
Apr 21, 2020
src/Symfony/Component/Validator/Resources/translations/validators.en.xlf
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 29, 2020
|
Hi @lmasforne |
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
|
@VincentLanglet seems to be ok ;) ; hope this PR will be merged soon |
|
@lmasforne Your PR have some CI-failures You need to fix https://fabbot.io/report/symfony/symfony/36368/46116925704192e42fd76f0f86fad8b60e028f65 Do you need help ? |
fabpot
added a commit
that referenced
this pull request
Aug 2, 2020
This PR was merged into the 5.2-dev branch. Discussion ---------- [Validator] Add Isin validator constraint Co-Authored-By: Yannis Foucher <33806646+YaFou@users.noreply.github.com> | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #36362 | License | MIT | Doc PR | symfony/symfony-docs#13960 Rebase of #36368 I asked him by mail and he didn't have time to finish the PR and allowed me to do it. Commits ------- 8e1ffc8 Feature #36362 add Isin validator constraint
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Aug 2, 2020
This PR was merged into the 5.2-dev branch. Discussion ---------- [Validator] Add Isin validator constraint Co-Authored-By: Yannis Foucher <33806646+YaFou@users.noreply.github.com> | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #36362 | License | MIT | Doc PR | symfony/symfony-docs#13960 Rebase of symfony/symfony#36368 I asked him by mail and he didn't have time to finish the PR and allowed me to do it. Commits ------- 8e1ffc8b99 Feature #36362 add Isin validator constraint
|
merged as #37565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ISIN validator constraint
see here for more details https://en.wikipedia.org/wiki/International_Securities_Identification_Number