[Validator] Use comparison constraints as attributes #38382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/comparison-constraints
branch
from
a960c30
to
0f36d4c
Compare
derrabus
changed the title
src/Symfony/Component/Validator/Constraints/NumberConstraintTrait.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
improvement/comparison-constraints
branch
from
0f36d4c
to
b5bdf82
Compare
fabpot
approved these changes
Oct 4, 2020
|
Thank you @derrabus. |
Merged
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables all child classes of
AbstractComparisonto be used as attributes.Some of those constraints used a trait called
NumberConstraintTraitfor a shared implementation. After my changes, that trait did not fit well anymore, so I've added a newZeroComparisonConstraintTraitas a replacement. Although I don't expectNumberConstraintTraitto provide much value outside of the Symfony codebase, I think we cannot safely change it because it was not labelled as@internal. This is basically why I went for the deprecation.