Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Remove abstract uid denormalization code #50558

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Jun 5, 2023

Q A
Branch? 7.0
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

Removes the code that was deprecated in #44721

@fancyweb fancyweb force-pushed the serializer/remove-auid-depr branch from 1506a6d to 1112805 Compare June 5, 2023 09:52
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 9a2d19f into symfony:7.0 Jun 5, 2023
6 checks passed
public function testSupportOurAbstractUid()
{
$this->expectDeprecation('Since symfony/serializer 6.1: Supporting denormalization for the "Symfony\Component\Uid\AbstractUid" type in "Symfony\Component\Serializer\Normalizer\UidNormalizer" is deprecated, use one of "Symfony\Component\Uid\AbstractUid" child class instead.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the ExpectDeprecationTrait can be removed when expectDeprecation is not called.

@fancyweb fancyweb deleted the serializer/remove-auid-depr branch June 30, 2023 07:32
nicolas-grekas added a commit that referenced this pull request Jun 30, 2023
…here it is not used (GromNaN)

This PR was merged into the 7.0 branch.

Discussion
----------

[Doctrine][Serializer] Remove `ExpectDeprecationTrait` where it is not used

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | n/a

This unused code has been left by #50558 and #50575.

I think PHPStan should detect when the trait is imported but the method `expectDeprecation` is not used.

Other PR for 6.4 #50828

Commits
-------

81972d3 Remove ExpectDeprecationTrait where it is not used
@fabpot fabpot mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants