[Serializer] Remove abstract uid denormalization code #50558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Jun 5, 2023
fancyweb
force-pushed
the
serializer/remove-auid-depr
branch
from
1506a6d
to
1112805
Compare
nicolas-grekas
force-pushed
the
serializer/remove-auid-depr
branch
from
1112805
to
79028f9
Compare
|
Thank you @fancyweb. |
GromNaN
reviewed
Jun 30, 2023
| public function testSupportOurAbstractUid() | ||
| { | ||
| $this->expectDeprecation('Since symfony/serializer 6.1: Supporting denormalization for the "Symfony\Component\Uid\AbstractUid" type in "Symfony\Component\Serializer\Normalizer\UidNormalizer" is deprecated, use one of "Symfony\Component\Uid\AbstractUid" child class instead.'); |
There was a problem hiding this comment.
Note that the ExpectDeprecationTrait can be removed when expectDeprecation is not called.
nicolas-grekas
added a commit
that referenced
this pull request
Jun 30, 2023
…here it is not used (GromNaN) This PR was merged into the 7.0 branch. Discussion ---------- [Doctrine][Serializer] Remove `ExpectDeprecationTrait` where it is not used | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | n/a This unused code has been left by #50558 and #50575. I think PHPStan should detect when the trait is imported but the method `expectDeprecation` is not used. Other PR for 6.4 #50828 Commits ------- 81972d3 Remove ExpectDeprecationTrait where it is not used
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the code that was deprecated in #44721