Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: translation:push command diff using intl-icu #19

Closed
wants to merge 1 commit into from

Conversation

Broutard
Copy link

Provider translations do not come back with "+intl-icu" in $provider->read($domains, $locales);, so local translations should not include it for the diff.

Provider translations do not come back with "+intl-icu" in `$provider->read($domains, $locales);`, so local translations should not include it for the diff.
@symfony-bot
Copy link

symfony-bot bot commented Oct 25, 2022

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/symfony

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply.

@Broutard Broutard closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant