Migrate PHPUnit configs and homogenize them #2867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
commented
Jun 25, 2025
smnandre
reviewed
Jun 26, 2025
smnandre
reviewed
Jun 26, 2025
smnandre
approved these changes
Jun 26, 2025
carsonbot
added
Status: Reviewed
Kocal
force-pushed
the
migrate-phpunit-config
branch
2 times, most recently
from
95b7e78 to
97e4215
Compare
|
I'm removing the |
Kocal
force-pushed
the
migrate-phpunit-config
branch
from
600748d to
061c314
Compare
Kocal
changed the title
Kocal
force-pushed
the
migrate-phpunit-config
branch
from
061c314 to
dfd4fe1
Compare
|
I removed some of last commits, and instead only focused on the PHPUnit configs migrations but also homogenization (with what https://github.com/symfony/symfony does). |
Kocal
added a commit
that referenced
this pull request
Jun 27, 2025
This PR was merged into the 2.x branch. Discussion ---------- [Translator][Tests] Minor fixes in tests context | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Cherry-picked from #2867, the following fixes only apply inside tests context, it does not have impact in real-life scenarios: 1. The static variable `$alreadyGenerated` now becomes a private property `alreadyGeneratedConstants. When tests were executed randomly in #2867, it was impossible to assert on generated translations files because constants names were kept in static cache even when the class `TranslationsDumper` was initialized for each test. 2. `self::$cacheDir` is a directory, so using `rmdir` is the best way to go instead of `unlink` Commits ------- 6e58d54 [Translator] Move already generated constants from static var to class property
Kocal
added a commit
that referenced
this pull request
Jun 28, 2025
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Tests] Fix functional tests Turbo | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Maybe I went to quick on #2867, maybe using `<server>` instead of `<env>` matters... **EDIT:** it seems that Turbo functional tests were broken since few weeks / months now, because of Chrome 137, see symfony/panther#675. Passing `PANTHER_DEVTOOLS=0` worked like a charm. Commits ------- 9b42f13 [Tests] Fix functional tests Turbo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get rid of: